Add marchid for rrv32 #1270
Merged
Add marchid for rrv32 #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a procedure I have not followed, a requirement I have not met, or a problem I have created? Edit: I've belatedly noticed that I didn't provide a link to rrv32's repository. I'm not sure why that slipped my mind. |
aswaterman
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
@SolraBizna Sorry, these PRs fall through the cracks sometimes.
ved-rivos
pushed a commit
to ved-rivos/riscv-isa-manual
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assigns ID 45 to rrv32, because that is the next
marchidin line. If permissible, I would prefer to use 1495879317 instead. This larger ID encodes a memorial to my father, who passed away 13 months ago. He set and guided me on the 25-year path that led to the creation of rrv32. That ID still has the high bit unset, which means it is technically within the open sourcemarchidspace. (However, I could easily see such a huge ID being inconvenient and annoying for those who want to make a simple lookup table formarchidvalues.)