Set PMP to create invalid address #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aap-sc
reviewed
Feb 2, 2024
debug/testlib.py
Outdated
|
|
||
| def reset_pmp_deny(self): | ||
| try: | ||
| import math |
There was a problem hiding this comment.
do you really need this import here?
debug/testlib.py
Outdated
| self.gdb.p("$pmpcfg0=0x98") # L, NAPOT, !R, !W, !X | ||
| self.gdb.p("$pmpaddr0=" | ||
| f"0x{((address >> 2) | ((size - 1) >> 3)):x}") | ||
| self.gdb.command("monitor riscv exec_progbuf 0x12000073") # 0x12000073 is sfence.vma |
There was a problem hiding this comment.
I would double-check if we need to flush register cache after modification of pmp* stuff
| self.gdb.command("monitor riscv exec_progbuf 0x12000073") # 0x12000073 is sfence.vma | ||
| except CouldNotFetch: | ||
| # PMP registers are optional | ||
| pass |
There was a problem hiding this comment.
- can you add some indication in the log that an attempt resulted in a some kind of exception?
- do you really need this
tryblock since you've introduced thissupport_set_pmp_denyproperty for the target?
Signed-off-by: liangzhen <zhen.liang@spacemit.com> Change-Id: I707281626521d321aadb6cee5aea457fc5c0424d
aswaterman
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hardware has full address coverage, so set PMP to create invalid address
Change-Id: I707281626521d321aadb6cee5aea457fc5c0424d