159 fix spec builds local and gh action #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the yml from the docs-template to build using Docker. Rename the file as build-pdf.yml.
Fix makefile and header file to build.
Add a wildcard to run action on any branch push.
Removed table font from header and updated version in Makefile.
|
This PR simply throws away all the Makefile improvements that we had done in the past which is not acceptable. |
|
This is how most of the other specs in the risc-v family of documents are setup. However, if you'd prefer to stick with your Makefile setup we'll have to find another way to fix the build. |
|
Cool. Feel free to kill off my PR. |
|
Closing this PR as the other PR #162 is already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated build to use Docker both for local builds and the GH Action build.