Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.am: fixed missing includes for make dist targets #1192

Open
wants to merge 1 commit into
base: riscv
Choose a base branch
from

Conversation

cetygamer
Copy link

No description provided.

en-sc
en-sc previously approved these changes Dec 25, 2024
Copy link
Collaborator

@en-sc en-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

LGTM

@aap-sc
Copy link
Collaborator

aap-sc commented Jan 11, 2025

@JanMatCodasip , @MarekVCodasip would you kindly take a look too?

@aap-sc
Copy link
Collaborator

aap-sc commented Jan 17, 2025

@JanMatCodasip , @MarekVCodasip would you kindly take a look too?

@JanMatCodasip gentle ping...

Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@en-sc @cetygamer I am sorry for my late reaction.

@cetygamer It looks like file field_helpers.h is also missing from the list. Would you like to add it?

Due to missing includes, make dist archives could not be built.

Signed-off-by: Alexander Rumyantsev <cetygamer@gmail.com>
@cetygamer
Copy link
Author

@JanMatCodasip, good catch! Added.

@en-sc en-sc requested a review from JanMatCodasip January 23, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants