feat: add amendment info #135

pdp2121 · 2023-09-20T19:51:00Z

High Level Overview of Change

Add a table to store amendments information:

Amendment’s hash
Amendment’s name
Enabled rippled version

This will also provide more stable source of truth for AmendmentEnabled transaction in Explorer, which hits 2 repos every time it was called.

This information will be accessed via /network/amendments/info endpoint.

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Tests (You added tests for code that already exists, or your new feature included in this PR)
Documentation Updates
Release

…ator-history-service into add-amendment-info

Co-authored-by: Mayukha Vadari <mvadari@ripple.com>

src/api/routes/v1/amendments.ts

package.json

src/api/routes/v1/index.ts

src/api/routes/v1/info.ts

src/connection-manager/amendments.ts

Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>

src/connection-manager/amendments.ts

src/connection-manager/index.ts

jonathanlei

LGTM other than @mvadari 's typo changes in the REGEX

src/connection-manager/amendments.ts

src/shared/database/setup.ts

Co-authored-by: Mayukha Vadari <mvadari@ripple.com>

src/api/routes/v1/amendments.ts

src/api/routes/v1/index.ts

src/shared/database/amendments.ts

mvadari · 2023-11-03T20:18:22Z

src/shared/database/amendments.ts

+    const response = await axios.get(
+      'https://raw.githubusercontent.com/XRPLF/xrpl-dev-portal/master/content/resources/known-amendments.md',


This is unrelated to this PR but I wonder if there's some way that this information can also be fetched from rippled. Seems difficult.

@intelliot @ckniffen any ideas on how we can fetch rippled version of each amendment by id?

The docs is the only place i know of.

src/shared/types/index.ts

ARCHITECTURE.md

pdp2121 and others added 24 commits July 12, 2023 15:54

add voting data to db

911badf

Merge branch 'main' into add-flag-ledger-data

063f26a

small doc fix

0a29875

use join for toString

0feeee8

add fee data for validators with no vote

88d5d81

remove master_key from ballot

b7dd5c2

remove master_key from Architecture

a82c4e1

Merge branch 'main' into add-flag-ledger-data

284699a

Merge branch 'main' into add-flag-ledger-data

89b340c

retrieve amendment info

bc61b68

Merge branch 'main' into add-amendment-info

60e8398

fix small issues

c0aac63

Merge branch 'add-amendment-info' of https://github.com/pdp2121/valid…

d3c0dcb

…ator-history-service into add-amendment-info

update api docs

a1cdcb2

small fix

9c63a57

version cleaned up + sorted

85441b5

add filter info by id and name

7beaf89

Merge branch 'main' into add-amendment-info

83367b4

update architecture

dc7cb8d

update link

148f71f

remove stale notifications

dc09a0b

add deprecation info

5bf1bc3

Update src/connection-manager/agreement.ts

3fb909c

Co-authored-by: Mayukha Vadari <mvadari@ripple.com>

Merge branch 'add-flag-ledger-data' into add-amendment-info

d3f4c9e