Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up Streams #897

Closed
wants to merge 26 commits into from
Closed

refactor: clean up Streams #897

wants to merge 26 commits into from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Dec 6, 2023

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

Before / After

Test Plan

@mvadari mvadari force-pushed the mv/refactor/streams branch from f7af59c to 2833c44 Compare December 6, 2023 18:41
@ckniffen
Copy link
Collaborator

Ran into a roadblock and decided to create incremental PRs for refactoring things to hooks so that they can leverage a useStreams hooks better #919 and #921.

@JST5000
Copy link
Contributor

JST5000 commented Feb 14, 2024

@ckniffen Should this PR be closed because the incremental PRs cover it? (Or is this PR trying to do something different?)

@ckniffen
Copy link
Collaborator

This can be closed. I will open up a new one with one with better iteration of the fix.

@JST5000
Copy link
Contributor

JST5000 commented Feb 15, 2024

Closing for now based on @ckniffen's above comment

@JST5000 JST5000 closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants