-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add EnsureCapacity
for dictionary types
#361
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 91.71% 91.91% +0.20%
==========================================
Files 109 126 +17
Lines 3379 3921 +542
Branches 438 544 +106
==========================================
+ Hits 3099 3604 +505
- Misses 189 210 +21
- Partials 91 107 +16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimothyMakkison thank you for this contribution, looks good!
#343 got merged in the meantime. Rebasing should work without too many conflicts if you first run dotnet tool restore && dotnet csharpier .
. We introduced csharpier to unify source code formatting and eliminate discussions around the source code format.
c204c44
to
d0adf71
Compare
dc6d358
to
408e847
Compare
🎉 This PR is included in version 2.8.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Resolves #251
ImplementsGeneric
to support interface inheritance, added a guard toTryBuildEnsureCapacity
becauseDictionary
does haveEnsureCapacity
for older versions.