Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed whitespace issue when generating if statement #394

Merged
merged 4 commits into from
Dec 3, 2020

Conversation

vallentin
Copy link
Collaborator

@vallentin vallentin commented Dec 3, 2020

Fixed #377
Closes #378

I've fixed the issue of whitespace being generated incorrectly in if statements.

I've tested all permutations from 1 to 4 branches. For which I created a Python script that generated all the permutations. I included the script as well, as it allows you to generate and test an arbitrary number of branches. (I'll use it to check match, macro, along with nested constructs later.)

I included the test cases for 1 and 2 branches.

@vallentin
Copy link
Collaborator Author

vallentin commented Dec 3, 2020

Forgot to push the updated test file.

@djc djc merged commit 5b01e60 into rinja-rs:main Dec 3, 2020
@djc
Copy link
Collaborator

djc commented Dec 3, 2020

Once again, thank you!

@vallentin vallentin deleted the fixes-377 branch December 3, 2020 21:14
@vallentin vallentin mentioned this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitespace issue with if conditions
2 participants