Allow paths to start with ::
#393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Dec 2, 2020
|
@djc can I write to you on Twitter, or do you have another better way for sending you a direct message? |
|
I'm everywhere! Twitter is fine, direct email, Tokio or Rust Discord, Askama Gitter, Mozilla Matrix, Rust Zulip... pick your poison. |
|
Alright, I'll send you a message in a bit. Just finishing up resolving #377. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331
I wanted to avoid changing
PathandPathCalland the parameters of the visit functions. So instead I decided to just prepend"::"to the path partsVec. If you'd rather have I add abooltoPathandPathCallI can do that instead.This does not introduce any breaking changes.