Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add build CI for windows #7

Merged
merged 12 commits into from
Jan 25, 2023
Merged

feat: add build CI for windows #7

merged 12 commits into from
Jan 25, 2023

Conversation

yihong0618
Copy link
Contributor

running_page use tzfpy now, and we found it does not support windows.
image

pprof can not compile on windows.

  1. need fix: pprof can not build on windows tzf-rs#36 merge first
  2. windows test can not pass for now. because we also need citiespy support windows too then we can add windows test ci

@yihong0618
Copy link
Contributor Author

Passed CI
https://github.com/yihong0618/tzfpy/actions/runs/4003349630/jobs/6871371815

@ringsaturn
Copy link
Owner

ringsaturn commented Jan 25, 2023 •
edited
Loading

Thanks, I will check citiespy’s Windows build.

Track here ringsaturn/go-cities.json#12

@yihong0618
Copy link
Contributor Author

Thanks, I will check citiespy’s Windows build.

when approve I will change the version in toml

ringsaturn pushed a commit to ringsaturn/tzf-rs that referenced this pull request Jan 25, 2023
@yihong0618
fix: pprof can not build on windows (#36)
4e331b1 
Refer:

- ringsaturn/tzfpy#7
@ringsaturn
Copy link
Owner

@yihong0618 Please bump tzf-rs to v0.2.1

@yihong0618
Copy link
Contributor Author

test added waiting for citiespy

@ringsaturn
Copy link
Owner

citiespy Windows support is ready: 0.3.3

@yihong0618
Copy link
Contributor Author

yihong0618 commented Jan 25, 2023 •
edited
Loading

@ringsaturn
finally passed in my actions...CI is hard work...

https://github.com/yihong0618/tzfpy/actions/runs/4003888133

do I need to rebase all commits or you just squash ?

ringsaturn
ringsaturn approved these changes Jan 25, 2023
View reviewed changes
Copy link
Owner

@ringsaturn ringsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fighting with CI!

@ringsaturn ringsaturn merged commit 3f7d94f into ringsaturn:main Jan 25, 2023
@ringsaturn
Copy link
Owner

It’s ready!

https://pypi.org/project/tzfpy/0.12.1/

@yihong0618 yihong0618 mentioned this pull request Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ringsaturn ringsaturn ringsaturn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihong0618 @ringsaturn