Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): delete_candidate and delete_candidate_on_current_page #900

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

ksqsf
Copy link
Member

@ksqsf ksqsf commented Jun 19, 2024

Previously, the two APIs will always delete the currently selected candidate, regardless of what its argument is.

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #899

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Previously, the two APIs will always delete the currently selected
candidate, regardless of what its argument is.
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eagleoflqj eagleoflqj merged commit 2f89098 into rime:master Jun 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete candidate APIs ignore index
2 participants