Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(log): add cmake option ALSO_LOG_TO_STDERR #809

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

lotem
Copy link
Member

@lotem lotem commented Feb 6, 2024

allow turning on/off glog's alsologtostderr flag in custom build.
by default OFF in release build, ON in debug build.

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #799

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

allow turning on/off glog's alsologtostderr flag in custom build.
by default OFF in release build, ON in debug build.

Fixes rime#799
@lotem lotem requested a review from a team February 7, 2024 11:56
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with emacs-rime. Can confirm this fixes the linked issue.

@lotem lotem merged commit 36eb14c into rime:master Feb 8, 2024
9 checks passed
@lotem lotem deleted the log branch February 8, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only log to a file without logging to stderr
2 participants