Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent initializing glog twice #745

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

eagleoflqj
Copy link
Member

@eagleoflqj eagleoflqj commented Oct 23, 2023

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Prevent initializing glog twice by using an API that is available in glog 0.7

Unit test

  • Done

Manual test

  • Done by duplicating rime->setup in rime_api_console.

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@eagleoflqj eagleoflqj marked this pull request as draft October 29, 2023 15:36
src/rime/setup.cc Show resolved Hide resolved
@eagleoflqj eagleoflqj mentioned this pull request Dec 18, 2023
2 tasks
@eagleoflqj eagleoflqj marked this pull request as ready for review June 17, 2024 22:19
@eagleoflqj eagleoflqj requested review from ksqsf and lotem June 17, 2024 22:19
@eagleoflqj eagleoflqj merged commit 79dda08 into rime:master Jun 18, 2024
10 checks passed
@eagleoflqj eagleoflqj deleted the init-glog branch June 18, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants