Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复使用多种translator共用的方案时日志频繁输出XXX made a futile translation问题 #623

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

siuze
Copy link
Contributor

@siuze siuze commented Mar 4, 2023

Pull request

Issue tracker

Fixes #569

Feature

使用DLOG而不是LOG打印日志

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

@LEOYoon-Tsaw
Copy link
Member

治標不治本吧

@siuze
Copy link
Contributor Author

siuze commented Mar 4, 2023

也可以这么说,不过我现阶段针对的只是【日志打印了不应在release版本打印的内容】这个问题,源代码看起来确实漏了一个字母“D”

Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the log before for loop is DLOG, it's indeed not intended to use LOG here.

@eagleoflqj eagleoflqj merged commit c9630fe into rime:master Sep 23, 2023
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于多方案混合输入情况下info日志中有很多Oops, got a futile translation.的疑问
3 participants