Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deep): fix Path.update not updating values correctly #80

Merged
merged 4 commits into from
May 28, 2022

Conversation

vitoke
Copy link
Contributor

@vitoke vitoke commented May 28, 2022

Fixes #79

@codecov-commenter
Copy link

Codecov Report

Merging #80 (8534f71) into main (b87eb80) will increase coverage by 2.48%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   85.70%   88.19%   +2.48%     
==========================================
  Files          56      211     +155     
  Lines        4492    13259    +8767     
  Branches      475     2710    +2235     
==========================================
+ Hits         3850    11694    +7844     
- Misses        554     1388     +834     
- Partials       88      177      +89     
Impacted Files Coverage Δ
packages/base/src/plain-object.ts 14.28% <ø> (ø)
packages/deep/src/protected.ts 50.00% <ø> (ø)
packages/reactor/src/hooks/useActorState.ts 100.00% <ø> (ø)
packages/deep/src/path.ts 100.00% <100.00%> (ø)
packages/reactor/src/controls/ObsStream.ts 100.00% <100.00%> (ø)
packages/reactor/src/hooks/useActor.ts 100.00% <100.00%> (ø)
packages/table/test-utils/table-standard-test.ts
packages/multiset/test/multiset-test-standard.ts
packages/graph/test/arrow-graph-test-standard.ts
packages/list/test/setupTests.ts
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87eb80...8534f71. Read the comment docs.

@vitoke vitoke merged commit 0a51a0a into main May 28, 2022
@vitoke vitoke deleted the fix/path-update-fix branch May 28, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Path.update does not update nested properties correctly
2 participants