fix(sorted): fix sortedset and sortedmap builders not correctly clearing their source when modified #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing their source when modified
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 96.96% 96.98% +0.02%
==========================================
Files 322 322
Lines 54740 54758 +18
Branches 6438 6444 +6
==========================================
+ Hits 53076 53106 +30
+ Misses 1652 1640 -12
Partials 12 12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188
SortedSet and SortedMap builders were using a piece of code to normalize their internal structures after being modified. However, this normalization did not correctly remove a reference to the original immutable instance after modification. This caused a
buildfrom the builder to use the immutable data structure as source, ignoring the modification. This has been fixed.