Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Local Multiplayer Support #128

Closed

Conversation

ianclawson
Copy link

@ianclawson ianclawson commented Jun 11, 2021

This PR (in a series of PRs for Local Multiplayer Support) unlocks the already-implemented multiple controller functionality waiting in Delta so that controllers may be assigned per-player and have correct inputs sent to DeltaCore.

Not opened in any PR is protocol conformance in the GBC, GBA, and melonDS cores. While local multiplayer support does not exist on those cores, they will still need to adopt the protocol, and may simply ignore the new incoming playerIndex var.

Other PRs:

Relevant Trello Cards:

@@ -294,7 +294,7 @@ extension SettingsViewController
let section = Section(rawValue: sectionIndex)!
switch section
{
case .controllers: return 1 // Temporarily hide other controller indexes until controller logic is finalized
case .controllers: return 4
case .controllerSkins: return System.registeredSystems.count
case .syncing: return SyncManager.shared.coordinator?.account == nil ? 1 : super.tableView(tableView, numberOfRowsInSection: sectionIndex)
default:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

override func controller() {deeznuts}

@ianclawson ianclawson closed this Aug 6, 2022
rileytestut added a commit that referenced this pull request Mar 1, 2023
Heavily based on Ian Clawson’s PRs, including #128
luf1k pushed a commit to playwithlu/Delta that referenced this pull request Jan 22, 2025
Heavily based on Ian Clawson’s PRs, including rileytestut#128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants