Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Receive 'Msg' type, add actor trait bound #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkj
Copy link
Contributor

@mkj mkj commented Jun 1, 2020

The Msg associated type of Receive trait isn't needed if we require that it's an Actor. It reduces a fair bit of boilerplate. The downside I see is that this forces Receive to be an Actor, though is that a problem?

This is more of a query than a solid pull request, but it's easier to show code examples here than an issue. There might be reasons why it won't work, of course it breaks compatibility too.

@leenozara
Copy link
Contributor

Hi @mkj I do think you're correct - Receive is just Actor. Since this is a change across core code I need to check the overall impact. Will come back to this in the next day or two.

@elenaf9
Copy link
Contributor

elenaf9 commented Jan 11, 2021

@leenozara what is the current status on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants