-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] - Public/Private Ownership - Central UI Changes #1096
Open
drewjhart
wants to merge
12
commits into
drew-hart--backend-public-private
Choose a base branch
from
drew-hart--publicprivate-ui
base: drew-hart--backend-public-private
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Backend] - Public/Private Ownership - Central UI Changes #1096
drewjhart
wants to merge
12
commits into
drew-hart--backend-public-private
from
drew-hart--publicprivate-ui
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
After discussing with the team (captured in the wiki here), we have decided to implement separate tables for Public and Private
GameTemplates
andQuestionTemplates
. This PR and the following one implement that strategy.They break down per:
[Backend] - Public/Private Ownership #1082
-> [Backend] - Public/Private Ownership - Central UI Changes #1096
->-> [Backend] - Public/Private - Bug Fixes #1101
The preceding PR (#1082) is focused around
networking
changes that provide the required updates to theschema.graphql
and the associatedAPIClients
. This PR (#1096) is focused around UI updates to ensure thatcentral
is functional. The following PR (#1101) cleans up some bugs.Note:
central
is currently undergoing a redesign. As such, these changes are implemented as easily as possible with limited changes to the codebase. We're going to need to rewritecentral
so I'm just adding in UI changes that are required to get the Public/Private setup off the groundUpdates:
The following UI updates are required to handle the new Public/Private set up:
owner
information toGame/Question Card
so that it "Created By: " can be displayed in the Public Games sectionedit
,clone
,delete
functions onGame/Question Card
so that they are limited for owner etcGameTemplate
andQuestionTemplate
creation. Disable these buttons when adding questions to games, etc, so that public games and public questions are always related, and vice-versausername
(this allows the username to get added to the owner field, instead of more sensitive email)