Better stack traces in the error page using Ben.Demystify #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's in the line bellow anyway and it seems to add quite a lot of noise to the nice Ben.Demystified method names.
|
Waits while Ben.Demystifier is not strongly-named. |
|
What is the problem with strong naming? |
|
I updated Ben.Demystifier to newest version and I allowed usage in owin projects. However owin requires strongly-named assembly. |
quigamdev
approved these changes
Dec 9, 2017
quigamdev
approved these changes
Dec 9, 2017
|
I updated Ben.Demystifier to newest version and I allowed usage in
owin projects.
Ok, that's cool.
However owin requires strongly-named assembly.
I don't want to know why... Anyway, I'd merge it for Asp.Net Core and
maybe add the support for OWIN later rather than waiting for the
strong-named package.
|
…ject - dependency cycle fixed
Owin requires strongly-named assembly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception stack traces for the Error Page now come from
EnhancedStackTracefrom the Ben.Demystify library. Because it's a bit experimental, it falls back to the normal stack traces transparently, so it should not break anything.Some screenshots (with highlighted cool stuff)
Note that it only works on
netstandard2.0target, notnet451, but it should not be a big deal as it's just a cosmetic change and you should be used to rough development experience if you are stuck to obsolete stuff :P