Added support for run arguments #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethauvin
commented
Aug 16, 2023
| } | ||
|
|
||
| @Test | ||
| void testGenerateInto() throws IOException { |
There was a problem hiding this comment.
This is the new test.
gbevin
reviewed
Aug 16, 2023
gbevin
reviewed
Aug 16, 2023
gbevin
reviewed
Aug 16, 2023
| */ | ||
| public static void generateInto(PublishInfo info, DependencyScopes dependencies, File file) | ||
| throws FileUtilsErrorException { | ||
| var pomBuilder = new PomBuilder(); |
There was a problem hiding this comment.
Maybe var pom_builder = new PomBuilder().info(info).dependencies(dependencies);
then remove the next two lines?
There was a problem hiding this comment.
Back to my original thoughts. Then you are also creating a couple additional objects. Yet it matches the builder pattern used throughout the code base.
Done. 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CLI option to include run arguments, e.g.:
I couldn't figure out how to add a test for this. I tested manually, and it seems to work with everything I could think of.