Add two new key binding a fix another one. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new bindings: one for help ('?') and another one to delete a view ('d'). The last one is in addition to the 'delete' key, since some browser bind this to "previous page in history".
Also, the correct key code (at least on Mac's QWERTY keyboard) for the letter 'h' is 72.
|
If there's a good reason to have vertical split bind to 87, let me know and I'll fix my patch. |
|
Ah, you're right, I was using w for hsplit. It probably should be h. :) I don't want to change delete's binding, though. 46 is delete, 8 is backspace. I'll merge your patch, but change that binding back. |
aphyr
added a commit
that referenced
this pull request
Feb 1, 2013
Add two new key binding a fix another one.
|
Thanks for adding the help window, too! Added you to the contributors file. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new bindings: one for help ('?') and another one to delete a view ('d'). The last one is in addition to the 'delete' key, since some browser bind this to "previous page in history".
Also, the correct key code (at least on Mac's QWERTY keyboard) for the letter 'h' is 72.