Log view does not limit the number of events #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've got a patch, right? >:-) |
|
I'm happy to take another look at fixing it, once I've a bit more time and have got my head round the way the views work :) |
|
It's a rather naive implementation, but this removes any old lines that are not in the most recent n lines (where n is |
|
Perfect. ;-) |
aphyr
added a commit
that referenced
this pull request
Feb 27, 2014
Log view does not limit the number of events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LogViewadded in0.2.8keeps appending new events without ever discarding previous events. Thelinesoption for the view implies it can be used to limit the number of log entries, but does not appear to do anything.