Expire using prioqueue #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 3, 2013 22:51
fetched from https://github.com/augustohp/Priority-Queue-NodeJS @ afae37d40
Every clock tick, check if the lowest priority item in the priority queue is in the past, and possibly expire it. This prevents events from stalling in the dashboard forever when they don't receive any more updates from riemann because thoses updates don't match the query used.
... instead of a global one, which breaks when there is more than one view per workspace
| @@ -109,6 +128,12 @@ var subs = (function() { | |||
| var event = JSON.parse(e.data); | |||
| event.time = Date.parse(event.time); | |||
| clock.advance(event.time); | |||
| if (event.ttl > 0) { // only expired events have no TTL | |||
There was a problem hiding this comment.
Not 100% sure about that actually...
Can an event with no TTL at all arrive here ? (undefined > 0) == false, so I guess it doesn't really matter.
There was a problem hiding this comment.
Events with a nil TTL should use a default of, say, 60 seconds.
ghost
merged commit 
|
do you think this may cause backwards compatibility issues, e.g. for users who prefer the old behaviour? |
|
I think this design is preferable. Fixes corner cases! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is basically where I am with this attempt to maintain a pseudo-index inside the dash, to be able to sweep out elements of the display which aren't updated by the websocket stream anymore, for whatever reason. It seems to work feature-wise, but I wouldn't exclude side-effects (I'm not used to writing javascript), and performance has not been taken in account.
I'll add a more couple comments inline where I have doubts and questions.
In any case, many thanks for the guidance @aphyr ! In retrospect, I'm impressed how small this patchset finally is. The code of the dash is really easy to navigate and pleasant to read, congrats !