Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow expired events in the grid and style with phonecian purple #29

Merged
1 commit merged into from May 7, 2013
Merged

Allow expired events in the grid and style with phonecian purple #29

1 commit merged into from May 7, 2013

Conversation

dch
Copy link

@dch dch commented May 6, 2013

This does what I want, but likely needs a solution to allow the expired events to be removed gracefully at some point from the dashboard.

I'm not sure what that would look like, so here's enough of a patch to spark the discussion.

purple

@ghost
Copy link

ghost commented May 7, 2013

Works for me! I wanted to avoid giving people the impression this was reliable, though, in the sense that if you open up the dashboard, you're never going to see expired events that happened before you arrived--expired means riemann no longer knows anything about them. ;-) With that in mind, it probably makes sense to use this visual cue once, then fade out the event after a few seconds.

ghost pushed a commit that referenced this pull request May 7, 2013
…vents

Allow expired events in the grid and style with phonecian purple
@ghost ghost merged commit f658493 into riemann:master May 7, 2013
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant