[apache#1355] fix(client): Netty client will leak when decoding respo…

…nses
rickyma · Jan 16, 2024 · 55bcb03 · 55bcb03
1 parent 2b77d46
commit 55bcb03
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/common/src/main/java/org/apache/uniffle/common/netty/TransportFrameDecoder.java b/common/src/main/java/org/apache/uniffle/common/netty/TransportFrameDecoder.java
@@ -81,12 +81,10 @@ public void channelRead(ChannelHandlerContext ctx, Object data) {
   }
 
   static boolean shouldRelease(Message msg) {
-    if (msg == null || msg.body() == null) {
+    if (msg == null || msg.body() == null || msg.body().byteBuf() == null) {
       return true;
     }
-    boolean shouldRelease =
-        msg.body().byteBuf() != null && msg.body().byteBuf().readableBytes() == 0;
-    return shouldRelease;
+    return msg.body().byteBuf().readableBytes() == 0;
   }
 
   private void clear() {