This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
rework SessionClient #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2015
| @@ -1,26 +1,44 @@ | |||
| package com.orbitz.consul; | |||
There was a problem hiding this comment.
I think it'd be worthwhile to test providing no fields in session creation, as well as a test specifying all fields and asserting that they are set correctly.
In particular I'm not sure that the TTL value of "30s" issue raised by @defucius has been addressed
There was a problem hiding this comment.
Also need a test for the renewSession action
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SessionClientto use objects instead of JSON strings./v1/session/list