This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Preventing intermittent test failure #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth a shot. The shippable build has failed on this a few times. |
rickfast
added a commit
that referenced
this pull request
Jan 24, 2015
Preventing intermittent test failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's hard to reproduce. I think I was victim to a timing/stale cache issue with the consul agent itself. It appears that recently deregistered services are still available via the /health/ api. I know that there's not much motive for merging, but if it helps, none of my subsequent development experienced intermittent failures after adding this in.