This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Asynchronous key/value store #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One PR is cool. Thanks for adding the async k/v methods. I've been meaning to do that before 1.0. Thanks again! I'll publish a new version tomorrow morning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two methods to get
Valueobjects from the key/value store asynchronously and to watch for changes.I also changed the index variable from int to long in the
QueryOptionsBuilderandQueryOptionsto reflect the changes made toConsulResponse. Is this ok or should I open a separate PR?