Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

use PUT method according to agent/deregister additional QueryOptions … #249

Merged
merged 1 commit into from
Jul 12, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/main/java/com/orbitz/consul/AgentClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,19 @@ public void register(Registration registration) {
register(registration, QueryOptions.BLANK);
}


/**
* De-register a particular service from the Consul Agent.
*/
public void deregister(String serviceId, QueryOptions options) {
handle(api.deregister(serviceId, options.toQuery()));
}

/**
* De-register a particular service from the Consul Agent.
*/
public void deregister(String serviceId) {
handle(api.deregister(serviceId));
deregister(serviceId, QueryOptions.BLANK);
}

/**
Expand Down Expand Up @@ -591,8 +599,8 @@ interface Api {
Call<Void> register(@Body Registration registration,
@QueryMap Map<String, Object> options);

@GET("agent/service/deregister/{serviceId}")
Call<Void> deregister(@Path("serviceId") String serviceId);
@PUT("agent/service/deregister/{serviceId}")
Call<Void> deregister(@Path("serviceId") String serviceId, @QueryMap Map<String, Object> options);

@PUT("agent/check/register")
Call<Void> registerCheck(@Body Check check);
Expand Down