This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Create new client url method #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes a consul client based on URL string
|
thanks! i will cut a new version (0.9.2) later this morning |
|
Thanks a lot! Really appreciate your work on this. |
|
np. 0.9.2 is now available in jcenter: |
|
Hi Rick, are you sure you build from master after merge? I downloaded 0.9.2 without the changes :-(. Thanks a lot. |
|
Yeah. Just pulled the tag. I screwed something up. Apologies. I'll remedy tomorrow morning |
|
0.9.3 is available, and should have everything you need. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Rick, hi folks,
Would be very useful to create a consul client just from a given url, like the standard constructor does.
For example do we use HTTPS tunneling to our consul cloud instance and our host uses some url rewriting that we can't avoid in URL path. So best deal will be to directly choose the target url as string for us.
Kind regards,
Robin