This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Clarify comment about having to continuously check in for TTL checks #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone is only starting out with Consul they may think calling `pass()` once, like in the example, is enough. For example they may think the client library will ensure the Dead Man Switch is maintained. Moving the comment about the user being responsible to be next to the `pass()` call should make it more clear for new users.
|
I made this mistake so I'm hoping to save others :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone is only starting out with Consul they may think calling
pass()once, like in the example, is enough. For example they may think the client library will ensure the Dead Man Switch is maintained. Moving the comment about the user being responsible to be next to thepass()call should make it more clear for new users.