This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Exposes listeners in ConsulCache #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -202,6 +202,14 @@ public boolean addListener(Listener<K, V> listener) { | |||
| return added; | |||
| } | |||
|
|
|||
| public Iterable<Listener<K, V>> getListeners() { | |||
There was a problem hiding this comment.
I'd suggest returning an ImmutableList or Collections.unmodifiable list here, it's generally iffy to give control of our member variables to other classes.
For example, if in the future additional logic is add in to addListener/removeListener then this could give people a way to remove listeners without triggering that logic.
There was a problem hiding this comment.
Sure, I can change that and even remove the count method, as we can expose the listeners as a list, not Iterable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I was wondering if it's ok for you guys to expose the listeners from a
ConsulCache. We need to access at least the number of listeners registered to a cache, so we can stop it once all listeners are removed, for example.I've exposed in this pull request the size of the list, plus the list itself as an
Iterable. Feel free to rename the methods if its not following your code pattern or something.Thanks again!