This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Adds HealthCheckCache for health api /v1/health/state/<state> #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HealthClienthas a api with support for blocking requests that enables us to filter health checks by state. UsingConsulCacheit is possible to offer the listener functionality for that api as well.This pull request adds an asynchronous implementation of
HealthClient#getChecksByState, and an implementation ofConsulCachecalledHealthCheckCache, that mapsHealthCheckby its check id.We are using this internally already in out stack, hope its all good for you to merge it.
Let me know if there are any issues or something missing that I can fix.
Thanks!