Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

ServiceHealthCache constructor drops QueryOptions #250

Closed
alugowski opened this issue Jul 14, 2017 · 0 comments · Fixed by #251
Closed

ServiceHealthCache constructor drops QueryOptions #250

alugowski opened this issue Jul 14, 2017 · 0 comments · Fixed by #251

Comments

@alugowski
Copy link
Contributor

alugowski commented Jul 14, 2017

This constructor accepts a QueryOptions argument, but then ignores it and forwards QueryOptions.BLANK instead:

https://github.com/OrbitzWorldwide/consul-client/blob/0.16.1/src/main/java/com/orbitz/consul/cache/ServiceHealthCache.java#L75

public static ServiceHealthCache newCache(
        final HealthClient healthClient,
        final String serviceName,
        final boolean passing,
        final QueryOptions queryOptions,
        final int watchSeconds) {
    return newCache(healthClient, serviceName, passing, watchSeconds, QueryOptions.BLANK);
}

A temporary workaround is to use the other constructor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant