Avoid coupling LinkControl test to css class (WordPress#20190)

* Select by user-perceivable text content and not CSS selector (implementation detail).

We’ve already seen this test break due to a change in CSS selector. Let’s avoid that in future.

See WordPress@38f4914

* Removes legacy comments

Should have been removed in WordPress@b9f1466

packages/block-editor/src/components/link-control/test/index.js

@@ -122,9 +122,10 @@ describe( 'Basic rendering', () => {
 			} );
 
 			// Click the "Edit" button to trigger into the editing mode.
-			const editButton = container.querySelector(
-				'.block-editor-link-control__search-item-action'
-			);
+			const editButton = Array.from(
+				container.querySelectorAll( 'button' )
+			).find( ( button ) => button.innerHTML.includes( 'Edit' ) );
+
 			act( () => {
 				Simulate.click( editButton );
 			} );
@@ -176,7 +177,6 @@ describe( 'Searching for a link', () => {
 		// fetchFauxEntitySuggestions resolves on next "tick" of event loop
 		await eventLoopTick();
 
-		// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 		const searchResultElements = getSearchResults();
 
 		let loadingUI = container.querySelector( '.components-spinner' );
@@ -215,7 +215,6 @@ describe( 'Searching for a link', () => {
 		// fetchFauxEntitySuggestions resolves on next "tick" of event loop
 		await eventLoopTick();
 
-		// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 		const searchResultElements = getSearchResults();
 
 		const firstSearchResultItemHTML = first( searchResultElements )
@@ -263,7 +262,6 @@ describe( 'Searching for a link', () => {
 			// fetchFauxEntitySuggestions resolves on next "tick" of event loop
 			await eventLoopTick();
 
-			// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 			const searchResultElements = getSearchResults();
 
 			const lastSearchResultItemHTML = last( searchResultElements )
@@ -316,7 +314,6 @@ describe( 'Manual link entry', () => {
 			// fetchFauxEntitySuggestions resolves on next "tick" of event loop
 			await eventLoopTick();
 
-			// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 			const searchResultElements = getSearchResults();
 
 			const firstSearchResultItemHTML =
@@ -363,7 +360,6 @@ describe( 'Manual link entry', () => {
 				// fetchFauxEntitySuggestions resolves on next "tick" of event loop
 				await eventLoopTick();
 
-				// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 				const searchResultElements = getSearchResults();
 
 				const firstSearchResultItemHTML =
@@ -400,7 +396,6 @@ describe( 'Default search suggestions', () => {
 		// Search Input UI
 		const searchInput = getURLInput();
 
-		// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 		const searchResultsWrapper = container.querySelector(
 			'[role="listbox"]'
 		);
@@ -496,7 +491,6 @@ describe( 'Default search suggestions', () => {
 
 		expect( searchInput.value ).toBe( searchTerm );
 
-		// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 		searchResultElements = getSearchResults();
 
 		// delete the text
@@ -506,7 +500,6 @@ describe( 'Default search suggestions', () => {
 
 		await eventLoopTick();
 
-		// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 		searchResultElements = getSearchResults();
 
 		searchInput = getURLInput();
@@ -635,7 +628,6 @@ describe( 'Selecting links', () => {
 				// fetchFauxEntitySuggestions resolves on next "tick" of event loop
 				await eventLoopTick();
 
-				// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 				const searchResultElements = getSearchResults();
 
 				const firstSearchSuggestion = first( searchResultElements );
@@ -715,7 +707,6 @@ describe( 'Selecting links', () => {
 					Simulate.keyDown( searchInput, { keyCode: DOWN } );
 				} );
 
-				// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 				const searchResultElements = getSearchResults();
 
 				const firstSearchSuggestion = first( searchResultElements );
@@ -822,7 +813,6 @@ describe( 'Selecting links', () => {
 
 			await eventLoopTick();
 
-			// TODO: select these by aria relationship to autocomplete rather than arbitary selector.
 			const searchResultElements = getSearchResults();
 
 			const firstSearchSuggestion = first( searchResultElements );