Fixed: Unnecessary wake up signals when submitting jobs

richardbiely · Oct 28, 2024 · d0c2a7a · d0c2a7a
1 parent 57b2ef7
commit d0c2a7a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 16 deletions.
diff --git a/include/gaia/mt/threadpool.h b/include/gaia/mt/threadpool.h
@@ -206,7 +206,6 @@ namespace gaia {
 
 				const auto prio = (JobPriority)jobHandle.prio();
 				auto& jobQueue = m_jobQueue[(uint32_t)prio];
-				auto& cv = m_cv[(uint32_t)prio];
 
 				if GAIA_UNLIKELY (m_workers.empty()) {
 					(void)jobQueue.try_push(jobHandle);
@@ -218,9 +217,6 @@ namespace gaia {
 				// The thread is put to sleep if pushing the jobs fails.
 				while (!jobQueue.try_push(jobHandle))
 					poll(prio);
-
-				// Wake some worker thread
-				cv.notify_one();
 			}
 
 		private:
@@ -234,7 +230,6 @@ namespace gaia {
 
 				const auto prio = (JobPriority)jobHandle.prio();
 				auto& jobQueue = m_jobQueue[(uint32_t)prio];
-				auto& cv = m_cv[(uint32_t)prio];
 
 				if GAIA_UNLIKELY (m_workers.empty()) {
 					(void)jobQueue.try_push(jobHandle);
@@ -248,9 +243,6 @@ namespace gaia {
 				// The thread is put to sleep if pushing the jobs fails.
 				while (!jobQueue.try_push(jobHandle))
 					poll(prio);
-
-				// Wake some worker thread
-				cv.notify_one();
 			}
 
 		public:

diff --git a/single_include/gaia.h b/single_include/gaia.h
@@ -14914,7 +14914,6 @@ namespace gaia {
 
 				const auto prio = (JobPriority)jobHandle.prio();
 				auto& jobQueue = m_jobQueue[(uint32_t)prio];
-				auto& cv = m_cv[(uint32_t)prio];
 
 				if GAIA_UNLIKELY (m_workers.empty()) {
 					(void)jobQueue.try_push(jobHandle);
@@ -14926,9 +14925,6 @@ namespace gaia {
 				// The thread is put to sleep if pushing the jobs fails.
 				while (!jobQueue.try_push(jobHandle))
 					poll(prio);
-
-				// Wake some worker thread
-				cv.notify_one();
 			}
 
 		private:
@@ -14942,7 +14938,6 @@ namespace gaia {
 
 				const auto prio = (JobPriority)jobHandle.prio();
 				auto& jobQueue = m_jobQueue[(uint32_t)prio];
-				auto& cv = m_cv[(uint32_t)prio];
 
 				if GAIA_UNLIKELY (m_workers.empty()) {
 					(void)jobQueue.try_push(jobHandle);
@@ -14956,9 +14951,6 @@ namespace gaia {
 				// The thread is put to sleep if pushing the jobs fails.
 				while (!jobQueue.try_push(jobHandle))
 					poll(prio);
-
-				// Wake some worker thread
-				cv.notify_one();
 			}
 
 		public: