Remove upper boundaries from requirements #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richardARPANET please have a look at it. I'm running your lib with following latest versions of its dependencies without any issues:
PS: your original repo is no longer accessible... (https://code.richard.do/richardARPANET/imdb-pie) |
|
@richardARPANET could this PR be accepted? |
This to allow to use the higher versions to resolve possible conflicts when used in combinatin with other libs who need the higher versions.
h3llrais3r
force-pushed
the
requirements-update
branch
from
75c300a to
7856ba4
Compare
|
@richardARPANET |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using imdbpie in combination with other libraries packaged inside my application.
However, the upper boundaries on the requirements are too strict and preventing me to install the newer versions.
Removing the upper boundaries in the requirements solves the issue.
In case a newer version should have issues again, we can always put back an upper boundary for that library.