Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback for 0x78 Pending response #60

Open
mamert opened this issue Jan 13, 2021 · 2 comments
Open

Callback for 0x78 Pending response #60

mamert opened this issue Jan 13, 2021 · 2 comments

Comments

@mamert
Copy link

mamert commented Jan 13, 2021

"pending" responses are silently ignored.

I have a branch which adds a callback triggered whenever they're received:
https://github.com/mamert/python-uds/tree/callback_for_0x78_pending

e.g. :

def samplePendingCallback(msg):
    print(f"0x78 Pending received while waiting for response to {msg}")
    
uds_bus = Uds(reqId=req_id, resId=res_id, defaultPendingCallback=samplePendingCallback)  # for every call
# OR
response = uds_bus.send([0x22, 0xF1, 0x86], pendingCallback=samplePendingCallback)  # just this one

I wanted to ask if this is worth creating a PR for (since It's a niche thing),
and if so, where to put an example

@richClubb
Copy link
Owner

richClubb commented Jan 13, 2021 via email

@aaknitt
Copy link

aaknitt commented Mar 17, 2021

The ability to extend the receive timeout based on reception of a 0x78 Pending would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants