Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): allow zero padding #625

Merged

Conversation

SarjuHansaliya
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • Currently it does not allow padding to be ZERO.

Issue Number: #623

What is the new behavior?

  • This PR add change to allow padding to be ZERO.
  • Padding UI is changed from Segment control to Select component.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

codesandbox bot commented Jan 13, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Jan 13, 2024

🦋 Changeset detected

Latest commit: 29df7d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@codeimage/app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SarjuHansaliya
Copy link
Contributor Author

Thanks @riccardoperra for the feedback, I will look into it

@SarjuHansaliya
Copy link
Contributor Author

@riccardoperra When you get a chance, can you please check my replies and let me know your thoughts

@SarjuHansaliya SarjuHansaliya force-pushed the feat/add_padding_zero branch from 4a3940c to 29df7d7 Compare March 23, 2024 16:46
@SarjuHansaliya
Copy link
Contributor Author

@riccardoperra New changes are ready to review. Please review when you get a chance.

@riccardoperra
Copy link
Owner

riccardoperra commented Apr 15, 2024

Hi @SarjuHansaliya, the code is ok but I miss some time currently. I'll merge it but I'll deploy together with other features in a tbd date.

I appreciate your help 😄

@riccardoperra riccardoperra merged commit 4d27d14 into riccardoperra:main Apr 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants