Remove warnings when compiling in browser + speedup #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the typescript libraries were provided via tsvfs.createDefaultMapFromCDN which includes additional definition files that we do not use, including dom.d.ts This produces irrelevant warnings when compiling the typescript source files in the browser. We now generate a lib_dts.ts, similar to behavior_dts.ts, which contains the relevant library files that are used during compilation. An added benefit is that compilation feels faster than before.
swazrgb
changed the title
ribrdb
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove warnings when compiling in browser + speedup
Previously the typescript libraries were provided via tsvfs.createDefaultMapFromCDN which includes additional definition files that we do not use, including dom.d.ts
This produces irrelevant warnings when compiling the typescript source files in the browser. We now generate a lib_dts.ts, similar to behavior_dts.ts, which contains the relevant library files that are used during compilation.
An added benefit is that compilation feels faster than before.