Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jq -r to strip quotes #23

Merged
merged 1 commit into from
Oct 4, 2023
Merged

use jq -r to strip quotes #23

merged 1 commit into from
Oct 4, 2023

Conversation

linde12
Copy link
Contributor

@linde12 linde12 commented Oct 4, 2023

Use jq -r .release.tag_name in order to strip the extra quotes you get from jq otherwise.

Before a version could look like this: "1.2.3"
With this change it becomes: 1.2.3

This also affetcts branch names so instead of changelog-"1.2.3" we get changelog-1.2.3. This is good because fetching branches containing quotes can cause issues on Windows systems.

Use `jq -r .release.tag_name` in order to strip the extra quotes you get
from `jq` otherwise.

Before a version could look like this: "1.2.3"
With this change it becomes: 1.2.3

This also affetcts branch names so instead of changelog-"1.2.3" we get
changelog-1.2.3. This is good because fetching branches containing
quotes can cause issues on Windows systems.
@linde12
Copy link
Contributor Author

linde12 commented Oct 4, 2023

Example of Windows error which is fixed by removing the quotes:

$ git pull
error: cannot lock ref 'refs/remotes/origin/changelog-"0.1.2-beta.1"': Unable to create 'C:/Path/To/Repo/.git/refs/remotes/origin/changelog-"0.1.2-beta.1".lock': Invalid argument

@rhysd rhysd merged commit 158451a into rhysd:master Oct 4, 2023
@rhysd
Copy link
Owner

rhysd commented Oct 4, 2023

Thanks for catching this.

@linde12
Copy link
Contributor Author

linde12 commented Oct 18, 2023

@rhysd No, thank you for the action!

Any plans on releasing soon, or should we go with using @master for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants