Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate production environment #46

Merged
merged 4 commits into from
May 31, 2018
Merged

Accommodate production environment #46

merged 4 commits into from
May 31, 2018

Conversation

rdebeasi
Copy link
Contributor

@rdebeasi rdebeasi commented May 14, 2018

This PR includes fixes for problems I encountered when working on deploying to redhat.com.

  • Move id="tech-stack" from <body> to <div>, because Drupal doesn't let you modify the body ID. The diff looks crazy because the indentation changed, but otherwise I just added a new <div> element and moved the ID over. (This change had previously been made in prod but not GitHub.)
  • Move the URLs of the lock and delete icons from app.js to index.html, so that their paths can be updated along with the rest of the image paths when deploying. (Previously, the production copy of app.js had been modified to point to the production URLs, and deploying a new version clobbered this change.)
  • Add instructions on updating redhat.com version, store them in Google Docs behind a Red Hat login, and link to them from the readme.

@rdebeasi rdebeasi requested a review from mcanoy May 23, 2018 21:10
@rdebeasi rdebeasi requested review from oybed and removed request for mcanoy May 31, 2018 19:46
Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested and working

@oybed oybed merged commit 7623a16 into rht-labs:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants