feat: Bump PO to v0.66.0 #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioferh
force-pushed
the
bump_PO_to_v0.66.0
branch
9 times, most recently
from
15840dc
to
ebf97fc
Compare
marioferh
force-pushed
the
bump_PO_to_v0.66.0
branch
3 times, most recently
from
97fc1c4
to
526803f
Compare
|
/retest checks/e2e-tests-olm |
|
@marioferh please rebase this PR ;) |
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
marioferh
force-pushed
the
bump_PO_to_v0.66.0
branch
2 times, most recently
from
16f768b
to
7029254
Compare
marioferh
force-pushed
the
bump_PO_to_v0.66.0
branch
from
3296300
to
427c5d9
Compare
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
marioferh
force-pushed
the
bump_PO_to_v0.66.0
branch
from
427c5d9
to
9890ab5
Compare
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
marioferh
force-pushed
the
bump_PO_to_v0.66.0
branch
from
9890ab5
to
e445132
Compare
|
/lgtm |
| @@ -23,6 +23,8 @@ import ( | |||
| "k8s.io/apimachinery/pkg/util/wait" | |||
| ) | |||
|
|
|||
| const CustomForeverTestTimeout = 40 * time.Second | |||
There was a problem hiding this comment.
(nit) feel free to ignore but I'd name the constant in an explicit manner for clarity...
Suggested change
| const CustomForeverTestTimeout = 40 * time.Second | |
| const DefaultTestTimeout = 40 * time.Second |
| @@ -53,7 +54,7 @@ func newSinglePrometheusRule(t *testing.T, name, expr string) *monv1.PrometheusR | |||
| Rules: []monv1.Rule{{ | |||
| Alert: "alert name", | |||
| Expr: intstr.FromString(expr), | |||
| For: "15m", | |||
| For: &durationFifteenMinutes, | |||
There was a problem hiding this comment.
suggestion for a follow-up PR
Suggested change
| For: &durationFifteenMinutes, | |
| For: ptr.To(monv1.Duration("15m")), |
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
simonpasquier
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump PO to v0.66.0