Skip to content

Commit

Permalink
Remove upper case constants (flutter#13)
Browse files Browse the repository at this point in the history
Remove usage of upper-case constants.

Updates SDK version to 2.0.0-dev.17.0
  • Loading branch information
lrhn authored Apr 17, 2018
1 parent 158826c commit 856c083
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 24 deletions.
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ language: dart

dart:
- dev
- stable
- 1.23.0

dart_task:
- test: --platform vm
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.3.5

- Updated SDK version to 2.0.0-dev.17.0

## 1.3.4

* Modify code to eliminate Future flattening.
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: pool
version: 1.3.4
version: 1.3.5
author: Dart Team <misc@dartlang.org>
description: A class for managing a finite pool of resources.
homepage: https://github.com/dart-lang/pool
dependencies:
async: ">=1.4.0 <3.0.0"
stack_trace: ">=0.9.2 <2.0.0"
environment:
sdk: ">=1.23.0 <2.0.0"
sdk: ">=2.0.0-dev.17.0 <2.0.0"
dev_dependencies:
fake_async: ">=0.1.0 <0.2.0"
test: ">=0.12.0 <0.13.0"
40 changes: 20 additions & 20 deletions test/pool_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,11 @@ void main() {
var resource = await pool.request();
var onReleaseCalled = false;
resource.allowRelease(() => onReleaseCalled = true);
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
expect(onReleaseCalled, isFalse);

expect(pool.request(), completes);
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
expect(onReleaseCalled, isTrue);
});

Expand All @@ -195,7 +195,7 @@ void main() {

var onReleaseCalled = false;
resource.allowRelease(() => onReleaseCalled = true);
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
expect(onReleaseCalled, isTrue);
});

Expand All @@ -208,11 +208,11 @@ void main() {

var completer = new Completer();
resource.allowRelease(() => completer.future);
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
expect(requestComplete, isFalse);

completer.complete();
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
expect(requestComplete, isTrue);
});

Expand All @@ -233,7 +233,7 @@ void main() {
onRelease1Called = true;
return completer1.future;
});
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
expect(onRelease1Called, isTrue);

var onRelease2Called = false;
Expand All @@ -242,7 +242,7 @@ void main() {
onRelease2Called = true;
return completer2.future;
});
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
expect(onRelease2Called, isTrue);
expect(request1Complete, isFalse);
expect(request2Complete, isFalse);
Expand All @@ -251,12 +251,12 @@ void main() {
// was triggered by the second blocking request, it should complete the
// first one to preserve ordering.
completer2.complete();
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
expect(request1Complete, isTrue);
expect(request2Complete, isFalse);

completer1.complete();
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
expect(request1Complete, isTrue);
expect(request2Complete, isTrue);
});
Expand Down Expand Up @@ -286,7 +286,7 @@ void main() {
var resource = await pool.request();
resource.release();

await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
});

group("close()", () {
Expand Down Expand Up @@ -323,7 +323,7 @@ void main() {
expect(pool.close(), completes);

resource1.allowRelease(() => completer.future);
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);

completer.complete();
});
Expand All @@ -347,11 +347,11 @@ void main() {

resource1Released = true;
resource1.release();
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);

resource2Released = true;
resource2.release();
await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);

var resource3 = await resource3Future;
resource3Released = true;
Expand All @@ -372,10 +372,10 @@ void main() {
}),
completes);

await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
pool.close();

await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
completer.complete();
});

Expand All @@ -396,10 +396,10 @@ void main() {
}),
completes);

await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
completer1.complete();

await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
completer2.complete();
});

Expand All @@ -414,10 +414,10 @@ void main() {
}),
completes);

await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
resource.allowRelease(() => completer.future);

await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
completer.complete();
});

Expand All @@ -431,7 +431,7 @@ void main() {
expect(pool.done, throwsA("oh no!"));
expect(pool.close(), throwsA("oh no!"));

await new Future.delayed(Duration.ZERO);
await new Future.delayed(Duration.zero);
completer.completeError("oh no!");
});
});
Expand Down

0 comments on commit 856c083

Please sign in to comment.