Merge pull request flutter#19 from dart-lang/cli_output_updates

some updates to the output for the progress display
rhencke · May 19, 2017 · 31c64f5 · 31c64f5
2 parents f737350 + 8655d7d
commit 31c64f5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## unreleased
+
+- Updated to the output for indeterminate progress
+
 ## 0.1.0
 
 - Use the new `Platform.resolvedExecutable` API to locate the SDK

diff --git a/lib/cli_logging.dart b/lib/cli_logging.dart
@@ -201,15 +201,17 @@ class _AnsiProgress extends Progress {
       bool showTiming: false}) {
     String char = kAnimationItems[_index % kAnimationItems.length];
     if (isFinal || cancelled) {
-      char = ' ';
+      char = '';
     }
     io.stdout.write('${ansi.backspace}${char}');
     if (isFinal || cancelled) {
       if (message != null) {
-        io.stdout.write(message);
+        io.stdout.write(message.isEmpty ? ' ' : message);
       } else if (showTiming) {
         String time = (elapsed.inMilliseconds / 1000.0).toStringAsFixed(1);
         io.stdout.write('${time}s');
+      } else {
+        io.stdout.write(' ');
       }
       io.stdout.writeln();
     }