-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyright sanity check #42
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚨 Try these New Features:
|
a3c3f3f
to
bf79396
Compare
Evidently network access is not allowed in pre-commit ci. 🤦 |
b714626
to
9ce4b24
Compare
e2bdf1b
to
abc5354
Compare
There ended up being a lot of changes to get this working. I can break them into separate PRs, especially things like reducing the duplicate runs for of unit tests. |
I added another pre-commit check to show the diff when |
abc5354
to
0455bff
Compare
This is expected to fail until #44 is merged. |
Path objects are immutable and closer to the intended final type.
Network access in not allowed, which prevents pyright installation. pre-commit-ci/issues#55
Adjust when the checks run
0455bff
to
04415ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's roll.
Fix a few bugs/errors discovered by the type checker.
Add type narrowing hints in the config classes to get accurate attribute checking.
Change default values that can be a
str
orPath
object toPath
objects.Add a pre-commit check for easy local testing but use a GitHub action to run type checking in CI. Pre-commit CI doses not allow network access, which prevents installation of
pyright
.Depends on #44.