Improve logging #24
Merged
Improve logging #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
samdoran
reviewed
Nov 6, 2024
| @@ -13,7 +13,7 @@ def handle_history_read(config: Config) -> dict: | |||
|
|
|||
| filepath = config.history.file | |||
| if not filepath or not filepath.exists(): | |||
| logging.warning(f"History file {filepath} does not exist.") | |||
| logging.warning("History file %s does not exist.", filepath) | |||
There was a problem hiding this comment.
What's the reason for moving away from f-strings here?
There was a problem hiding this comment.
Fixing ruff/pyright linting warning for lazy logging
There was a problem hiding this comment.
I believe this is G004. TIL. Are we going to enable that in the pyproject.toml?
There was a problem hiding this comment.
We can. I will add it in another PR.
The --verbose command line switch will enable log in terminal
Add some basic logging configuration to save the logs in a file and output to the terminal as minimal as possible
r0x0d
force-pushed
the
improve-logging
branch
from
6833723 to
53383e9
Compare
r0x0d
force-pushed
the
improve-logging
branch
from
53383e9 to
c47ca6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.