[RSPEED-480] Add String size limit to SQLAlchemy models #123

r0x0d · 2025-01-20T13:24:35Z

Fixed a bug where MySQL/MariaDB would not write to interactions table since VARCHAR requires a fixed length size

Jira Issues:

RSPEED-480

Checklist

Jira issue has been made public if possible
[RSPEED-] is part of the PR title
PR title explains the change from the user's point of view
Code and tests are documented properly
The commits are squashed to as few commits as possible (without losing data)

codecov · 2025-01-20T13:40:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines	Coverage Δ
command_line_assistant/config/schemas.py	`87.50% <ø> (ø)`
...d_line_assistant/daemon/database/models/history.py	`100.00% <100.00%> (ø)`

major · 2025-01-20T13:50:18Z

command_line_assistant/config/schemas.py

@@ -11,6 +11,14 @@
 class DatabaseSchema:
    """This class represents the [history.database] section of our config.toml file.

+    Notes:


Helpful note! 👏

Fixed a bug where MySQL/MariaDB would not write to interactions table since VARCHAR requires a fixed length size

r0x0d requested review from a team as code owners January 20, 2025 13:24

r0x0d changed the title ~~Minor fixes for database and docs~~ [RSPEED-480] Minor fixes for database and docs Jan 20, 2025

r0x0d force-pushed the minor-fixes-for-database-and-docs branch 4 times, most recently from 81403cb to 3b7d1d6 Compare January 20, 2025 13:32

major approved these changes Jan 20, 2025

View reviewed changes

r0x0d force-pushed the minor-fixes-for-database-and-docs branch from 3b7d1d6 to ed63055 Compare January 20, 2025 13:50

Add String size limit to SQLAlchemy models

6355ee1

Fixed a bug where MySQL/MariaDB would not write to interactions table since VARCHAR requires a fixed length size

r0x0d force-pushed the minor-fixes-for-database-and-docs branch from ed63055 to 6355ee1 Compare January 20, 2025 13:51

r0x0d changed the title ~~[RSPEED-480] Minor fixes for database and docs~~ [RSPEED-480] Add String size limit to SQLAlchemy models Jan 20, 2025

r0x0d merged commit 8f8cb60 into rhel-lightspeed:main Jan 20, 2025
21 checks passed

r0x0d deleted the minor-fixes-for-database-and-docs branch January 20, 2025 15:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RSPEED-480] Add String size limit to SQLAlchemy models #123

[RSPEED-480] Add String size limit to SQLAlchemy models #123

r0x0d commented Jan 20, 2025 •

edited

Loading

codecov bot commented Jan 20, 2025 •

edited

Loading

major Jan 20, 2025

[RSPEED-480] Add String size limit to SQLAlchemy models #123

[RSPEED-480] Add String size limit to SQLAlchemy models #123

Conversation

r0x0d commented Jan 20, 2025 • edited Loading

codecov bot commented Jan 20, 2025 • edited Loading

Codecov Report

major Jan 20, 2025

Choose a reason for hiding this comment

r0x0d commented Jan 20, 2025 •

edited

Loading

codecov bot commented Jan 20, 2025 •

edited

Loading