Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSPEED-416] Migrate JSON history cache to database solution #108

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented Jan 13, 2025

This patch introduces a migration from the old JSON format to a database format. This allow us to switch between sqlite, postgresql and mysql, giving the user more autonomy, security and control over their database.

Jira Issues:

Checklist

  • Jira issue has been made public if possible
  • [RSPEED-] is part of the PR title
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)

@r0x0d r0x0d requested review from a team as code owners January 13, 2025 18:05
@r0x0d r0x0d force-pushed the database-history branch 4 times, most recently from 20dfdf7 to 493ff52 Compare January 13, 2025 18:55
This patch introduces a migration from the old JSON format to a database
format. This allow us to switch between sqlite, postgresql and mysql,
giving the user more autonomy, security and control over their database.
@r0x0d r0x0d force-pushed the database-history branch 8 times, most recently from 6db2a22 to 4cbdd02 Compare January 14, 2025 13:06
Copy link

Based on your Packit configuration the settings of the @rhel-lightspeed/command-line-assistant Copr project would need to be updated as follows:

field old value new value
chroots ['epel-10-aarch64', 'epel-10-x86_64', 'epel-9-x86_64', 'epel-9-aarch64'] ['centos-stream-10-aarch64', 'centos-stream-10-x86_64', 'epel-10-aarch64', 'epel-10-x86_64', 'epel-9-aarch64', 'epel-9-x86_64', 'rhel-9-aarch64', 'rhel-9-x86_64']

Diff of chroots:

+centos-stream-10-aarch64
+rhel-9-x86_64
+rhel-9-aarch64
+centos-stream-10-x86_64

Packit was unable to update the settings above as it is missing admin permissions on the @rhel-lightspeed/command-line-assistant Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the @rhel-lightspeed/command-line-assistant Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

@r0x0d r0x0d merged commit 923fe63 into rhel-lightspeed:develop Jan 14, 2025
15 checks passed
@r0x0d r0x0d deleted the database-history branch January 14, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant